A class variable that overrides an instance variable should still display as instance variable #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one, as soon as a class variable has an inherited member of type instance variable, it become an instance variable as well.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #692 +/- ##
==========================================
+ Coverage 92.66% 92.68% +0.02%
==========================================
Files 47 47
Lines 8169 8180 +11
Branches 1955 1959 +4
==========================================
+ Hits 7570 7582 +12
Misses 343 343
+ Partials 256 255 -1
☔ View full report in Codecov by Sentry. |
|
It’s missing a change log entry. But otherwise looks good to me. |
tristanlatr
commented
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671